linux-kernel - Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcOExYiT2zIBm8ie@shaak>
Date:   Wed, 22 Dec 2021 15:04:21 -0500
From:   Liam Beguin <liambeguin@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Peter Rosin <peda@...ntia.se>, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing
 function

On Wed, Dec 22, 2021 at 09:50:28PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 9:42 PM Liam Beguin <liambeguin@...il.com> wrote:
> > On Wed, Dec 22, 2021 at 08:52:30PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 22, 2021 at 8:20 PM Liam Beguin <liambeguin@...il.com> wrote:
> > > > On Wed, Dec 22, 2021 at 12:21:01PM +0200, Andy Shevchenko wrote:
> > > > > On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin <liambeguin@...il.com> wrote:
> 
> ...
> 
> > > > > Missed types.h and forward declarations like
> 
> ^^^^ (1)
> 
> > > > > struct device;
> > > >
> > > > Okay. will add linux/types.h
> 
> ^^^^ (2)
> 
> > > What about forward declaration?
> >
> > I'm not sure I understand what you mean here.
> 
> In (1) I have mentioned header and forward declaration. You agreed in
> (2) to add a header. What about forward declaration?

Oh, understood, sorry I misread your message.

I'll add `struct device;` above `struct rescale;`.

Cheers,
Liam

> -- 
> With Best Regards,
> Andy Shevchenko