linux-kernel - Re: [PATCH] sfc: Check null pointer of rx_queue->page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 12:26:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Martin Habets <habetsm.xilinx@...il.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     ecree.xilinx@...il.com, davem@...emloft.net, ast@...nel.org,
        daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] sfc: Check null pointer of rx_queue->page_ring

On Wed, 22 Dec 2021 13:03:56 +0000 Martin Habets wrote:
> On Mon, Dec 20, 2021 at 09:56:03PM +0800, Jiasheng Jiang wrote:
> > Because of the possible failure of the kcalloc, it should be better to
> > set rx_queue->page_ptr_mask to 0 when it happens in order to maintain
> > the consistency.
> > 
> > Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")
> > Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>  
> 
> Acked-by: Martin Habets <habetsm.xilinx@...il.com>

Applied, thanks!