linux-kernel - Re: [PATCH] crypto: hisilicon/qm - cleanup warning in qm_vf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0915e7b7-05e7-6e96-60e8-2a3113cf337a@huawei.com>
Date:   Thu, 23 Dec 2021 10:16:14 +0800
From:   "yekai(A)" <yekai13@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "wangzhou1@...ilicon.com" <wangzhou1@...ilicon.com>
Subject: Re: [PATCH] crypto: hisilicon/qm - cleanup warning in qm_vf_read_qos



On 2021/12/23 9:51, Andy Shevchenko wrote:
>
>
> On Wednesday, December 22, 2021, Kai Ye <yekai13@...wei.com
> <mailto:yekai13@...wei.com>> wrote:
>
>     The kernel test rebot report this warning: Uninitialized variable: ret.
>     Here is fix it.
>
>
> How do you know that 0 is the correct value?
>
>
>
>     Signed-off-by: Kai Ye <yekai13@...wei.com <mailto:yekai13@...wei.com>>
>     ---
>      drivers/crypto/hisilicon/qm.c | 3 +--
>      1 file changed, 1 insertion(+), 2 deletions(-)
>
>     diff --git a/drivers/crypto/hisilicon/qm.c
>     b/drivers/crypto/hisilicon/qm.c
>     index b1fe9c7b8cc8..c6e9ad2041c3 100644
>     --- a/drivers/crypto/hisilicon/qm.c
>     +++ b/drivers/crypto/hisilicon/qm.c
>     @@ -4279,8 +4279,7 @@ static void qm_vf_get_qos(struct hisi_qm *qm,
>     u32 fun_num)
>
>      static int qm_vf_read_qos(struct hisi_qm *qm)
>      {
>     -       int cnt = 0;
>     -       int ret;
>     +       int cnt = 0, ret = 0;
>
>             /* reset mailbox qos val */
>             qm->mb_qos = 0;
>     --
>     2.33.0
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
we set the 0 to success in kernel style.

thanks
Kai