linux-kernel - Re: [PATCH] scsi: bsg: Ignore bsg queue registration failures again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211223063446.GA4005@lst.de>
Date:   Thu, 23 Dec 2021 07:34:46 +0100
From:   Christoph Hellwig <hch@....de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Jackie Liu <liuyun01@...inos.cn>
Subject: Re: [PATCH] scsi: bsg: Ignore bsg queue registration failures again

On Wed, Dec 22, 2021 at 08:54:27AM -0800, Guenter Roeck wrote:
> Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when
> scsi_bsg_register_queue() fails"), errors from registering the bsg queue
> are no longer ignored but returned to the caller. At the same time, the
> comment in the code still states that errors are ignored. On top of that,
> the message preporting the problem is printed as dev_info, not dev_err.
> Both suggest that errors from bsg queue registrations should indeed be
> ignored.

But there is no good reason to ignore it.  The proper fix is to fully
handle the errors.