linux-kernel - Re: [PATCH] HID: holtek-mouse: start hardware in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcQfil1zb908p2hs@kroah.com>
Date:   Thu, 23 Dec 2021 08:04:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "James D. Turner" <linuxkernel.foss@...rc-none.turner.link>
Cc:     linux-kernel@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] HID: holtek-mouse: start hardware in probe

On Tue, Dec 21, 2021 at 09:21:41PM -0500, James D. Turner wrote:
> The holtek_mouse_probe() function is missing the necessary code to
> start the hardware. When an Etekcity Scroll X1 (M555) USB mouse is
> plugged in, the mouse receives power and the kernel recognizes it as a
> USB device, but the system does not respond to any movement, clicking,
> or scrolling of the mouse. Presumably, this bug also affects all other
> mice supported by the hid-holtek-mouse driver, although this has not
> been tested. On the stable linux-5.15.y branch, testing confirms that
> the bug was introduced in commit a579510a64ed ("HID: check for valid
> USB device for many HID drivers"), which was first included in
> v5.15.8. Based on the source code, this bug appears to be present in
> all currently-supported kernels (mainline, stable, and all LTS
> kernels). Testing on hardware confirms that this proposed patch fixes
> the bug for kernel v5.15.10. Fix holtek_mouse_probe() to call the
> necessary functions to start the hardware.
> 
> Fixes: 93020953d0fa ("HID: check for valid USB device for many HID drivers")
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Cc: linux-input@...r.kernel.org
> Cc: stable@...r.kernel.org
> Signed-off-by: James D. Turner <linuxkernel.foss@...rc-none.turner.link>
> ---
> This is my first time submitting a kernel patch. I think I've followed
> all the directions, but please let me know if I should do something
> differently.
> 
> In addition to testing this patch for the stable v5.15.10 kernel on real
> hardware, I also tested it for the latest master of the hid repository
> (commit 03090cc76ee3 ("Merge branch 'for-linus' of
> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid")) using a VM with
> USB passthrough.

Thanks for the patch, but isn't this the same as commit 93a2207c254c
("HID: holtek: fix mouse probing") in Linus's tree right now?

thanks,

greg k-h