linux-kernel - Re: [PATCH v1 1/1] wwan: Replace kernel.h with the necessary inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNKnsSuo52J0Az_fNfRUj6P8CCZMWm+SVkYjoik_Py74N6Yzg@mail.gmail.com>
Date:   Thu, 23 Dec 2021 13:46:05 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH v1 1/1] wwan: Replace kernel.h with the necessary inclusions

On Thu, Dec 23, 2021 at 1:18 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Thu, Dec 23, 2021 at 12:14:09PM +0200, Andy Shevchenko wrote:
>> On Wed, Dec 22, 2021 at 11:38:44PM +0300, Sergey Ryazanov wrote:
>>> On Wed, Dec 22, 2021 at 7:32 PM Andy Shevchenko
>>> <andriy.shevchenko@...ux.intel.com> wrote:
>
> ...
>
>> Not sure what it's supposed from me to do. The forward declarations are
>> the tighten part of the cleanup (*) and it's exactly what is happening here,
>> i.e.  replacing kernel.h "with the list of what is really being used".
>>
>> *) Either you need a header, or you need a forward declaration, or rely on
>>    the compiler not to be so strict. I prefer the second option out of three.
>
> Ah, seems indeed the skbuf and netdevice ones can be split. Do you want me to
> resend as series of two?

No. The single patch cleanup looks pretty good.

It might be worth pointing out in the commit message that the other
included headers were removed as they indirectly include the kernel.h
header. This will be helpful for future readers. But I don’t think
such a comment is worth a patch update. So I am Ok if this patch will
be applied as is.

> (Sorry I have sent many similar changes and haven't remembered by heart where
>  I did what exactly, but here it looks natural to cleanup that stuff at the
>  same time, so the question is if it should be a separate change or not)

The patch looks good. Thank you for this hard cleanup work!

-- 
Sergey