linux-kernel - Re: Re: [PATCH v3] serial: mps2-uart: Check for error irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211223132733.1400381-1-jiasheng@iscas.ac.cn>
Date:   Thu, 23 Dec 2021 21:27:33 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     robin.murphy@....com, andy.shevchenko@...il.com,
        gregkh@...uxfoundation.org, jirislaby@...nel.org,
        liviu.dudau@....com, sudeep.holla@....com,
        lorenzo.pieralisi@....com
Cc:     linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH v3] serial: mps2-uart: Check for error irq

On 2021-12-23 12:54, Robin Murphy wrote:
>> Because of the possible failure of the platform_get_irq(), it should be
>> better to check it to avoid the use of error irq.
>
> As far as I can see, the only "use" of error values is that they will be 
> passed to request_irq(), which will then return -EINVAL because they are 
> not valid IRQ numbers, and that error will be handled appropriately. I 
> think that's a relatively common pattern, so your commit message should 
> really describe why you think it's a problem and why this addition is a 
> meaningful improvement.

Thanks for your reminder, and I correct my commit message as follow.
If that's ok, I will correct my other patches like this.

For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the request_irq().
So it might be better to check just now in order to avoid the waste of
later processes.

Sincerely thanks,
Jiasheng