linux-kernel - Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfGmn8+3=qx1-jqO+yO4zFgS854LcVm1tDSwhz5BnJF0A@mail.gmail.com>
Date:   Thu, 23 Dec 2021 15:49:59 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andreas Kemnade <andreas@...nade.info>,
        Alistair Francis <alistair23@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Henrik Rydberg <rydberg@...math.org>,
        Mylène Josserand <mylene.josserand@...tlin.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen

On Mon, Dec 6, 2021 at 9:05 AM Alistair Francis <alistair@...stair23.me> wrote:
>
> From: Mylène Josserand <mylene.josserand@...tlin.com>
>
> This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> controllers. This driver supports only the I2C bus but it uses regmap
> so SPI support could be added later.
> The touchscreen can retrieve some defined zone that are handled as
> buttons (according to the hardware). That is why it handles
> button and multitouch events.

Most of the comments I just gave against v2 are applicable here,
please address them.

-- 
With Best Regards,
Andy Shevchenko