linux-kernel - RE: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e678fa4d9d14a3d892e829bfc7524e6@realtek.com>
Date:   Fri, 24 Dec 2021 07:03:30 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Yu-Tung Chang <mtwget@...il.com>,
        "tony0620emma@...il.com" <tony0620emma@...il.com>
CC:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i


> -----Original Message-----
> From: Yu-Tung Chang <mtwget@...il.com>
> Sent: Friday, December 24, 2021 2:49 PM
> To: tony0620emma@...il.com
> Cc: kvalo@...nel.org; davem@...emloft.net; kuba@...nel.org; linux-wireless@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Yu-Tung Chang <mtwget@...il.com>
> Subject: [PATCH] rtw88: add quirk to disable pci caps on HP Slim Desktop S01-pF1000i
> 
> 8821CE causes random freezes on HP Slim Desktop S01-pF1000i. Add a quirk
> to disable pci ASPM capability.
> 
> Signed-off-by: Yu-Tung Chang <mtwget@...il.com>
> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
> index a7a6ebfaa203..f8999d7dee61 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1738,6 +1738,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
>  		},
>  		.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
>  	},
> +	{
> +		.callback = disable_pci_caps,
> +		.ident = "HP HP Slim Desktop S01-pF1xxx",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "HP Slim Desktop S01-pF1xxx"),
> +		},
> +		.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
> +	},
>  	{}
>  };
> 

A patch [1] is merged to fix freezes of 8821ce.

[1] https://lore.kernel.org/all/20211215114635.333767-1-kai.heng.feng@canonical.com/

--
Ping-Ke