[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YcWFrCjWSG65KQgb@kroah.com>
Date: Fri, 24 Dec 2021 09:32:44 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Quan Nguyen <quan@...amperecomputing.com>
Cc: Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh+dt@...nel.org>,
Lee Jones <lee.jones@...aro.org>,
Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
openbmc@...ts.ozlabs.org, Mark Brown <broonie@...nel.org>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Derek Kiernan <derek.kiernan@...inx.com>,
Dragan Cvetic <dragan.cvetic@...inx.com>,
Arnd Bergmann <arnd@...db.de>,
Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>,
Open Source Submission <patches@...erecomputing.com>,
Phong Vo <phong@...amperecomputing.com>,
"Thang Q . Nguyen" <thang@...amperecomputing.com>
Subject: Re: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error
monitor driver
On Fri, Dec 24, 2021 at 11:13:49AM +0700, Quan Nguyen wrote:
> This commit adds Ampere's SMpro error monitor driver for monitoring
> and reporting RAS-related errors as reported by SMpro co-processor
> found on Ampere's Altra processor family.
>
> Signed-off-by: Quan Nguyen <quan@...amperecomputing.com>
> ---
> Change in v6:
> + First introduced in v6 [Quan]
>
> drivers/mfd/smpro-mfd.c | 1 +
> drivers/misc/Kconfig | 7 +
> drivers/misc/Makefile | 1 +
> drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 580 insertions(+)
> create mode 100644 drivers/misc/smpro-errmon.c
You need Documentation/ABI/ updates when you add sysfs files. Please do
that for your next version of this patch.
Also remember that sysfs is only "one value per file", this driver seems
to violate that in huge ways and is not ok.
thanks,
greg k-h
Powered by blists - more mailing lists