linux-kernel - RE: [PATCH v3] rtw88: check for validity before using a pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <505cb763449e4b4ab493857e014e31a1@realtek.com>
Date:   Fri, 24 Dec 2021 09:00:54 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Yan-Hsuan Chuang <tony0620emma@...il.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Bernie Huang <phhuang@...ltek.com>,
        "open list:REALTEK WIRELESS DRIVER (rtw88)" 
        <linux-wireless@...r.kernel.org>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
CC:     "kernel@...labora.com" <kernel@...labora.com>
Subject: RE: [PATCH v3] rtw88: check for validity before using a pointer


> -----Original Message-----
> From: Muhammad Usama Anjum <usama.anjum@...labora.com>
> Sent: Friday, December 24, 2021 4:55 PM
> To: Yan-Hsuan Chuang <tony0620emma@...il.com>; Kalle Valo <kvalo@...nel.org>; David S. Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Pkshih <pkshih@...ltek.com>; Bernie Huang
> <phhuang@...ltek.com>; open list:REALTEK WIRELESS DRIVER (rtw88) <linux-wireless@...r.kernel.org>; open
> list:NETWORKING DRIVERS <netdev@...r.kernel.org>; open list <linux-kernel@...r.kernel.org>
> Cc: usama.anjum@...labora.com; kernel@...labora.com
> Subject: [PATCH v3] rtw88: check for validity before using a pointer
> 
> ieee80211_probereq_get() can return NULL. Pointer skb should be checked
> for validty before use. If it is not valid, list of skbs needs to be
> freed.
> 
> Fixes: 10d162b2ed39 ("rtw88: 8822c: add ieee80211_ops::hw_scan")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

[...]