linux-kernel - Re: [PATCH v6 2/2] Driver for ON Semi AR0521 camera sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Dec 2021 10:22:26 +0100
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Krzysztof Hałasa <khalasa@...p.pl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@....fi>
Subject: Re: [PATCH v6 2/2] Driver for ON Semi AR0521 camera sensor

Hi Joe

On Thu, Dec 23, 2021 at 12:13:10PM -0800, Joe Perches wrote:
> On Thu, 2021-12-23 at 19:48 +0100, Jacopo Mondi wrote:
> > The media subsystem requires to validate patches with
> >
> >         ./scripts/checkpatch.pl --strict --max-line-length=80
> >
> > We longly debated this and I believe it's now generally accepted to go
> > over 80 when it makes sense, but not regularly span to 120 cols like
> > in the previous version.
>
> Where is this documented and do you have a link to the debate?

It's in the subsystem maintainer profile
Documentation/driver-api/media/maintainer-entry-profile.rst

Where of course some exceptions are listed but it's anyway enforced
that "efforts should be made towards staying within 80
characters per line"

    - on strings, as they shouldn't be broken due to line length limits;
    - when a function or variable name need to have a big identifier name,
      which keeps hard to honor the 80 columns limit;
    - on arithmetic expressions, when breaking lines makes them harder to
      read;
    - when they avoid a line to end with an open parenthesis or an open
      bracket.

The debate I mentioned was specifically on the previous version of the
driver where me and Krzysztof shown quite different understanding of
coding style requirements.
https://patchwork.linuxtv.org/project/linux-media/patch/m3fstfoexa.fsf@t19.piap.pl/

That lead me to submit this
https://patchwork.linuxtv.org/project/linux-media/patch/20211013092005.14268-1-jacopo@jmondi.org/
which I never managed to re-send, my bad.


>
> The archive for the i2c mailing list doesn't show much debate:
>
> https://lore.kernel.org/linux-i2c/?q=%2280+columns%22
> https://lore.kernel.org/linux-i2c/?q=%22line+length%22
>
> Perhaps there should be a MAINTAINERS P: entry for this requirement.
>
> From MAINTAINERS:
>
> 	P: Subsystem Profile document for more details submitting
> 	   patches to the given subsystem. This is either an in-tree file,
> 	   or a URI. See Documentation/maintainer/maintainer-entry-profile.rst
> 	   for details.
>
>