linux-kernel - Re: [PATCH] tracing: fix mismatched comment in __string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211224224820.cd2f6b2289d7c741cf1f8ba6@kernel.org>
Date:   Fri, 24 Dec 2021 22:48:20 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Geliang Tang <geliang.tang@...e.com>
Cc:     "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Chuck Lever <chuck.lever@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: fix mismatched comment in __string_len

On Wed, 22 Dec 2021 19:00:25 +0800
Geliang Tang <geliang.tang@...e.com> wrote:

> Here __assign_str_len() should be used for the __string_len type, instead
> of __assign_str().
> 

Yeah, the comment in the above line is correct :)

Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

> Signed-off-by: Geliang Tang <geliang.tang@...e.com>
> ---
>  samples/trace_events/trace-events-sample.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
> index 5ab74fc9a2df..cbbbb83beced 100644
> --- a/samples/trace_events/trace-events-sample.h
> +++ b/samples/trace_events/trace-events-sample.h
> @@ -155,7 +155,7 @@
>   *
>   *         To assign this string, use the helper macro __assign_str_len().
>   *
> - *         __assign_str(foo, bar, len);
> + *         __assign_str_len(foo, bar, len);
>   *
>   *         Then len + 1 is allocated to the ring buffer, and a nul terminating
>   *         byte is added. This is similar to:
> -- 
> 2.31.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>