linux-kernel - Re: [PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 24 Dec 2021 18:46:10 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     "Shunzhou.Jiang" <shunzhou.jiang@...ogic.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, Neil Armstrong <narmstrong@...libre.com>,
        khilman@...libre.com, jbrunet@...libre.com, jianxin.pan@...ogic.com
Subject: Re: [PATCH] dt-bindings: power: add Amlogic s4 power doamins bindings

Hello,

first of all: thanks for working on this!

On Fri, Dec 24, 2021 at 8:17 AM Shunzhou.Jiang
<shunzhou.jiang@...ogic.com> wrote:
>
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
Here the spelling of "domains" is correct but in the subject line it's
not (the subject has: doamins)

> The bindings targets the Amlogic s4, in which the power domain registers
> are in secure world.
>
> Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@...ogic.com>
I found your name in an Android kernel maintainers file with a space
(instead of a dot): Shunzhou Jiang
In Germany a space between the names would be correct - but I can't
tell what's right or wrong for your case.

PS: as a small side-note: when using multiple patches we typically
send a cover-letter.
You can use the following patch-set/series as an example: [0]
It's not critical but it certainly helps identify which patches belong together.


Best regards,
Martin


[0] https://lore.kernel.org/linux-amlogic/20211214022100.14841-1-qianggui.song@amlogic.com/T/