linux-kernel - Re: [PATCH] soc: s4: Add support for power domains controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAFBinCCrpHoLCYMH8JMmdfoSx1004GcV1DrAvCbUwomB50ZBxA@mail.gmail.com>
Date:   Fri, 24 Dec 2021 18:59:26 +0100
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     "Shunzhou.Jiang" <shunzhou.jiang@...ogic.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Neil Armstrong <narmstrong@...libre.com>, khilman@...libre.com,
        jbrunet@...libre.com
Subject: Re: [PATCH] soc: s4: Add support for power domains controller

On Fri, Dec 24, 2021 at 8:22 AM Shunzhou.Jiang
<shunzhou.jiang@...ogic.com> wrote:
>
> Add support s4 Power controller. In s4, power control
> registers are in secure domain, and should be accessed by smc.
>
> Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@...ogic.com>
(The same comment about the name as in the dt-bindings patch applies though)

I don't have a datasheet to validate any of this but in general the
code-change is looking fine.

The subject should be changed to "soc: amlogic: meson-secure-pwrc: Add
support for the S4 SoC" or similar so it follows the general schema we
use there (see the git history)


Best regards,
Martin