[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YcYMi4QthNLF3j/f@ripper>
Date: Fri, 24 Dec 2021 10:08:11 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc: linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Prabhakar <prabhakar.csengg@...il.com>,
linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get
the interrupt
On Fri 24 Dec 08:13 PST 2021, Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
Regards,
Bjorn
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
> Hi,
>
> Dropping usage of platform_get_resource() was agreed based on
> the discussion [0].
>
> [0] https://patchwork.kernel.org/project/linux-renesas-soc/
> patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@...renesas.com/
>
> Cheers,
> Prabhakar
> ---
> drivers/slimbus/qcom-ngd-ctrl.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
> index 7040293c2ee8..0f29a08b4c09 100644
> --- a/drivers/slimbus/qcom-ngd-ctrl.c
> +++ b/drivers/slimbus/qcom-ngd-ctrl.c
> @@ -1526,13 +1526,11 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev)
> if (IS_ERR(ctrl->base))
> return PTR_ERR(ctrl->base);
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "no slimbus IRQ resource\n");
> - return -ENODEV;
> - }
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> + return ret;
>
> - ret = devm_request_irq(dev, res->start, qcom_slim_ngd_interrupt,
> + ret = devm_request_irq(dev, ret, qcom_slim_ngd_interrupt,
> IRQF_TRIGGER_HIGH, "slim-ngd", ctrl);
> if (ret) {
> dev_err(&pdev->dev, "request IRQ failed\n");
> --
> 2.17.1
>
Powered by blists - more mailing lists