linux-kernel - Re: [PATCH 1/4] mfd: intel_soc_pmic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 25 Dec 2021 16:20:04 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Lee Jones <lee.jones@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] mfd: intel_soc_pmic_crc: Sort cells by IRQ order

On Sat, Dec 25, 2021 at 1:55 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> The cells for the Crystal Cove PMIC are already mostly sorted by
> function / IRQ order. Move the ADC cell so that they are fully sorted.
>
> Also move some of the resource definitions so that their order matches
> the (new) order of the cells.


...

>  #define CRYSTAL_COVE_IRQ_GPIO          5


>         {

As Lee commented once in p2sb patch series I think it makes sense here
as well, i.e.

[CRYSTAL_COVE_IRQ_GPIO] = {

>                 .name = "crystal_cove_gpio",
>                 .num_resources = ARRAY_SIZE(gpio_resources),

What do you think?

-- 
With Best Regards,
Andy Shevchenko