linux-kernel - Re: [PATCH 3/3] mtd: rawnand: nandsim: Add NS_PAGE_BYTE_SHIFT macro to replace the repeat pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <812386103.202031.1640467048454.JavaMail.zimbra@nod.at>
Date:   Sat, 25 Dec 2021 22:17:28 +0100 (CET)
From:   Richard Weinberger <richard@....at>
To:     s921975628@...il.com
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] mtd: rawnand: nandsim: Add NS_PAGE_BYTE_SHIFT macro
 to replace the repeat pattern

----- Ursprüngliche Mail -----
> Von: s921975628@...il.com
> An: "richard" <richard@....at>, "Vignesh Raghavendra" <vigneshr@...com>, "Miquel Raynal" <miquel.raynal@...tlin.com>
> CC: "linux-mtd" <linux-mtd@...ts.infradead.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "RinHizakura"
> <s921975628@...il.com>
> Gesendet: Samstag, 25. Dezember 2021 11:07:13
> Betreff: [PATCH 3/3] mtd: rawnand: nandsim: Add NS_PAGE_BYTE_SHIFT macro to replace the repeat pattern

> From: RinHizakura <s921975628@...il.com>
> 
> The (ns->regs.column + ns->regs.off) pattern repeats a lot which
> represents the byte shift in next page to access. We can replace it
> with a macro to improve the readability.
> 
> Signed-off-by: RinHizakura <s921975628@...il.com>
> ---
> drivers/mtd/nand/raw/nandsim.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)

Reviewed-by: Richard Weinberger <richard@....at>

Thanks,
//richard