linux-kernel - Re: code conditional on non-existing PPC_EARLY_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y2481f2v.fsf@mpe.ellerman.id.au>
Date:   Sun, 26 Dec 2021 09:42:48 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Cc:     kernel-janitors <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: code conditional on non-existing PPC_EARLY_DEBUG_MICROWATT.

Christophe Leroy <christophe.leroy@...roup.eu> writes:
> Le 23/12/2021 à 11:21, Lukas Bulwahn a écrit :
>> Dear Benjamin, dear Paul, dear Michael,
>> 
>> with commit 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART
>> for console"), you have some code in arch/powerpc/kernel/udbg_16550.c,
>> conditional on the Kconfig symbol PPC_EARLY_DEBUG_MICROWATT. However,
>> since then, the definition of this Kconfig symbol was never introduced
>> to the mainline repository or current linux-next, nor am I finding any
>> pending patch for that.
>> 
>> Are you going to add this config definition soon? Or did you identify
>> that this setup code in udbg_16550.c is not actually needed and can we
>> simply drop this code again?
>> 
>> This issue was identified with the script ./scripts/checkkconfigsymbols.py.
>> 
>
> Was it forgotten when handling comments to 
> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20200509050340.GD1464954@thinks.paulus.ozlabs.org/ 
> ?

Yes. I reported it internally to some folks but I guess they haven't had
time to send a fixup patch.

I'm pretty sure we just need the first three hunks of that patch, but it
would be good if someone with a Microwatt setup could test it.

cheers