linux-kernel - Re: [PATCH] kernel: time: Return ENXIO instead of ENODEV when call smp_call_function_single fail in clockevents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b198847b-557e-542f-a3a2-9cc7cab72d45@emindsoft.com.cn>
Date:   Sat, 25 Dec 2021 13:21:08 +0800
From:   Chen Gang <chengang@...ndsoft.com.cn>
To:     tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: time: Return ENXIO instead of ENODEV when call
 smp_call_function_single fail in clockevents_unbind

Hello:

The original mail was not sent successfully, so I send it again with
another mailbox.

Thanks.

On 12/19/21 11:29 PM, gchen@...kywalker.com wrote:
> From: Chen Gang <gchen@...kywalker.com>
> 
> smp_call_function_single will return -ENXIO for failure, so ENXIO needs
> to be as the default value of cu.res for return instead of ENODEV.
> 
> Signed-off-by: Chen Gang <gchen@...kywalker.com>
> ---
>  kernel/time/clockevents.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 003ccf338d20..59b83bee03e6 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -416,7 +416,7 @@ static void __clockevents_unbind(void *arg)
>   */
>  static int clockevents_unbind(struct clock_event_device *ced, int cpu)
>  {
> -	struct ce_unbind cu = { .ce = ced, .res = -ENODEV };
> +	struct ce_unbind cu = { .ce = ced, .res = -ENXIO };
>  
>  	smp_call_function_single(cpu, __clockevents_unbind, &cu, 1);
>  	return cu.res;
>