linux-kernel - Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Dec 2021 10:40:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Chris Brandt <Chris.Brandt@...esas.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to
 get the interrupt

On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad
<prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com> wrote:

...

> > > +       if (np) {
> >
> > Same comments as per your other patches, i.e.
> > Why is this check here?
> >
> Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case.

Shouldn't be fixed in platform_get_irq_optional() to return IRQ by
index for all cases?

> [0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454


-- 
With Best Regards,
Andy Shevchenko