linux-kernel - Re: [PATCH] coccinelle: adjust the confidence of uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2112261141070.3217@hadrien>
Date:   Sun, 26 Dec 2021 11:45:16 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Qing Wang <wangqing@...o.com>
cc:     Gilles Muller <Gilles.Muller@...ia.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Michal Marek <michal.lkml@...kovi.net>, cocci@...teme.lip6.fr,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccinelle: adjust the confidence of
 uninitialized_var.cocci



On Tue, 14 Dec 2021, Qing Wang wrote:

> From: Wang Qing <wangqing@...o.com>
>
> Since uninitialized_var() was removed, this cocci should reset its
> confidence to low.

I'm not sure to understand the argument for this one.  The semantic patch
in its current state is looking for declarations that hide an
uninitialized variable.  The part about the uninitialized_var macro is not
there any more.  The problem that is searched for seems reasonable to
address.

julia

>
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  scripts/coccinelle/misc/uninitialized_var.cocci | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/misc/uninitialized_var.cocci b/scripts/coccinelle/misc/uninitialized_var.cocci
> index 69bbaae..79e02e3
> --- a/scripts/coccinelle/misc/uninitialized_var.cocci
> +++ b/scripts/coccinelle/misc/uninitialized_var.cocci
> @@ -18,7 +18,7 @@
>  /// this kind were cleaned-up from the kernel. This cocci rule checks that
>  /// the macro is not explicitly or implicitly reintroduced.
>  ///
> -// Confidence: High
> +// Confidence: Low
>  // Copyright: (C) 2020 Denis Efremov ISPRAS
>  // Options: --no-includes --include-headers
>  //
> --
> 2.7.4
>
>