| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202112261932.8hwlDwCu-lkp@intel.com>
Date: Sun, 26 Dec 2021 19:29:46 +0800
From: kernel test robot <lkp@...el.com>
To: Tony Huang <tonyhuang.sunplus@...il.com>, robh+dt@...nel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
derek.kiernan@...inx.com, dragan.cvetic@...inx.com, arnd@...db.de,
gregkh@...uxfoundation.org
Cc: kbuild-all@...ts.01.org, tony.huang@...plus.com,
wells.lu@...plus.com, Tony Huang <tonyhuang.sunplus@...il.com>
Subject: Re: [PATCH v5 2/2] misc: Add iop driver for Sunplus SP7021
Hi Tony,
I love your patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next linux/master linus/master v5.16-rc6 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tony-Huang/Add-iop-driver-for-Sunplus-SP7021/20211224-163743
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 1bb866dcb8cf5054de88f592fc0ec1f275ad9d63
config: powerpc64-randconfig-s032-20211226 (https://download.01.org/0day-ci/archive/20211226/202112261932.8hwlDwCu-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/a75af7615fe0101c6f3742afc005a39c66b00864
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tony-Huang/Add-iop-driver-for-Sunplus-SP7021/20211224-163743
git checkout a75af7615fe0101c6f3742afc005a39c66b00864
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/misc/ drivers/pinctrl/nuvoton/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
sparse warnings: (new ones prefixed by >>)
drivers/misc/sunplus_iop.c:94:39: sparse: sparse: cast removes address space '__iomem' of expression
drivers/misc/sunplus_iop.c:95:43: sparse: sparse: cast removes address space '__iomem' of expression
>> drivers/misc/sunplus_iop.c:100:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *p @@ got void [noderef] __iomem *[assigned] iop_kernel_base @@
drivers/misc/sunplus_iop.c:100:16: sparse: expected void *p
drivers/misc/sunplus_iop.c:100:16: sparse: got void [noderef] __iomem *[assigned] iop_kernel_base
drivers/misc/sunplus_iop.c:101:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *p @@ got void [noderef] __iomem *[assigned] iop_kernel_base @@
drivers/misc/sunplus_iop.c:101:16: sparse: expected void *p
drivers/misc/sunplus_iop.c:101:16: sparse: got void [noderef] __iomem *[assigned] iop_kernel_base
drivers/misc/sunplus_iop.c:103:47: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:103:47: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:103:47: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:105:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:105:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:105:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:107:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:107:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:107:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:109:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:109:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:109:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:111:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:111:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:111:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:113:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:113:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:113:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:115:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:115:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:115:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:118:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:118:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:118:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:120:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:120:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:120:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:122:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:122:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:122:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:124:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:124:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:124:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:130:39: sparse: sparse: cast removes address space '__iomem' of expression
drivers/misc/sunplus_iop.c:131:43: sparse: sparse: cast removes address space '__iomem' of expression
drivers/misc/sunplus_iop.c:136:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *p @@ got void [noderef] __iomem *[assigned] iop_kernel_base @@
drivers/misc/sunplus_iop.c:136:16: sparse: expected void *p
drivers/misc/sunplus_iop.c:136:16: sparse: got void [noderef] __iomem *[assigned] iop_kernel_base
drivers/misc/sunplus_iop.c:137:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *p @@ got void [noderef] __iomem *[assigned] iop_kernel_base @@
drivers/misc/sunplus_iop.c:137:16: sparse: expected void *p
drivers/misc/sunplus_iop.c:137:16: sparse: got void [noderef] __iomem *[assigned] iop_kernel_base
drivers/misc/sunplus_iop.c:139:47: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:139:47: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:139:47: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:141:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:141:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:141:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:143:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:143:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:143:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:145:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:145:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:145:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:147:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:147:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:147:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:149:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:149:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:149:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:151:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:151:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:151:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:154:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:154:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:154:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:156:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:156:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:156:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:158:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:158:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:158:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:160:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:160:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:160:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:171:39: sparse: sparse: cast removes address space '__iomem' of expression
drivers/misc/sunplus_iop.c:172:43: sparse: sparse: cast removes address space '__iomem' of expression
drivers/misc/sunplus_iop.c:173:47: sparse: sparse: cast removes address space '__iomem' of expression
drivers/misc/sunplus_iop.c:177:47: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:177:47: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:177:47: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:179:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:179:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:179:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:181:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:181:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:181:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:183:22: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:183:22: sparse: expected void const volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:183:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:185:22: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:185:22: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:185:22: sparse: got unsigned int *
drivers/misc/sunplus_iop.c:188:29: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int * @@
drivers/misc/sunplus_iop.c:188:29: sparse: expected void volatile [noderef] __iomem *addr
drivers/misc/sunplus_iop.c:188:29: sparse: got unsigned int *
vim +100 drivers/misc/sunplus_iop.c
91
92 static void sp_iop_normal_mode(struct sp_iop *iop)
93 {
94 struct regs_iop *p_iop_reg = (struct regs_iop *)iop->iop_regs;
95 struct regs_moon0 *p_moon0_reg = (struct regs_moon0 *)iop->moon0_regs;
96 void __iomem *iop_kernel_base;
97 unsigned int reg;
98
99 iop_kernel_base = ioremap(iop->iop_mem_start, NORMAL_CODE_MAX_SIZE);
> 100 memset(iop_kernel_base, 0, NORMAL_CODE_MAX_SIZE);
101 memcpy(iop_kernel_base, iop->iop_normal_code, NORMAL_CODE_MAX_SIZE);
102
103 writel(0x00100010, &p_moon0_reg->clken[0]);
104
105 reg = readl(&p_iop_reg->iop_control);
106 reg |= 0x01;
107 writel(reg, &p_iop_reg->iop_control);
108
109 reg = readl(&p_iop_reg->iop_control);
110 reg &= ~(0x8000);
111 writel(reg, &p_iop_reg->iop_control);
112
113 reg = readl(&p_iop_reg->iop_control);
114 reg |= 0x0200;//disable watchdog event reset IOP
115 writel(reg, &p_iop_reg->iop_control);
116
117 reg = (iop->iop_mem_start & 0xFFFF);
118 writel(reg, &p_iop_reg->iop_base_adr_l);
119 reg = (iop->iop_mem_start >> 16);
120 writel(reg, &p_iop_reg->iop_base_adr_h);
121
122 reg = readl(&p_iop_reg->iop_control);
123 reg &= ~(0x01);
124 writel(reg, &p_iop_reg->iop_control);
125 iop->mode = 0;
126 }
127
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists