[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211227113839.92352-1-jiapeng.chong@linux.alibaba.com>
Date: Mon, 27 Dec 2021 19:38:39 +0800
From: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To: davem@...emloft.net
Cc: kuba@...nel.org, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH v2] asix: Use min() instead of doing it manually
Eliminate following coccicheck warning:
./drivers/net/usb/asix_common.c:545:12-13: WARNING opportunity for
min().
Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
Changes in v2:
-Modified commmit message.
drivers/net/usb/asix_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index 71682970be58..da5a7df312d2 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -542,7 +542,7 @@ static int __asix_mdio_write(struct net_device *netdev, int phy_id, int loc,
out:
mutex_unlock(&dev->phy_mutex);
- return ret < 0 ? ret : 0;
+ return min(ret, 0);
}
void asix_mdio_write(struct net_device *netdev, int phy_id, int loc, int val)
--
2.20.1.7.g153144c
Powered by blists - more mailing lists