[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e689de7b-033b-0ada-5135-faf7fdb1e26b@roeck-us.net>
Date: Mon, 27 Dec 2021 07:43:12 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
mezin.alexander@...il.com
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] hwmon: Use min() instead of doing it manually
On 12/27/21 3:36 AM, Jiapeng Chong wrote:
> Eliminate following coccicheck warning:
>
> ./drivers/hwmon/nzxt-smart2.c:461:12-13: WARNING opportunity for min().
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> drivers/hwmon/nzxt-smart2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c
> index 534d39b8908e..b30de7441fbb 100644
> --- a/drivers/hwmon/nzxt-smart2.c
> +++ b/drivers/hwmon/nzxt-smart2.c
> @@ -458,7 +458,7 @@ static int send_output_report(struct drvdata *drvdata, const void *data,
>
> ret = hid_hw_output_report(drvdata->hid, drvdata->output_buffer,
> sizeof(drvdata->output_buffer));
> - return ret < 0 ? ret : 0;
> + return min(ret, 0);
Nack, that is just confusing. ret is an error if < 0, and min obfuscates
that we want to return an error or 0.
Guenter
Powered by blists - more mailing lists