linux-kernel - Re: [PATCH v3] ima: silence measurement list hexdump during kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41a6ff0500d362f4f03420b75cfe904ff2672f47.camel@linux.ibm.com>
Date:   Mon, 27 Dec 2021 10:54:12 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Bruno Meneguele <bmeneg@...hat.com>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ima: silence measurement list hexdump during kexec

On Mon, 2021-12-27 at 11:52 -0300, Bruno Meneguele wrote:
> The measurement list is being dumped during soft resets (kexec) through the
> call to print_hex_dump(KERN_DEBUG, ...) without considering the DEBUG
> compilation flag. With that, to avoid dumping this information to the system
> log whenever a soft reset happens during boot process, since the default
> console loglevel is generally set to 7 (debug) during boot, guard the call
> to print_hex_dump() with #ifdef for the DEBUG cflag.

The patch description needs to be rewritten/simplified.  If the only
problem is that "the console loglevel is generally set to 7 (debug)",
why not begin with the patch description with that?

Other things to consider including in the patch description:
- any side effects of the change (e.g. ability to dynamically enable
output)?

thanks,

Mimi