lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Dec 2021 16:06:39 +0900 From: Alexandre Courbot <acourbot@...omium.org> To: Dafna Hirschfeld <dafna.hirschfeld@...labora.com> Cc: Linux Media Mailing List <linux-media@...r.kernel.org>, kernel@...labora.com, Andrew-CT Chen <andrew-ct.chen@...iatek.com>, courbot@...omium.org, Dafna Hirschfeld <dafna3@...il.com>, eizan@...omium.org, houlong.wei@...iatek.com, Hsin-Yi Wang <hsinyi@...omium.org>, Hans Verkuil <hverkuil@...all.nl>, Irui Wang <irui.wang@...iatek.com>, LKML <linux-kernel@...r.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, Maoguang Meng (孟毛广) <maoguang.meng@...iatek.com>, Matthias Brugger <matthias.bgg@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, minghsiu.tsai@...iatek.com, Tomasz Figa <tfiga@...omium.org>, Tiffany Lin <tiffany.lin@...iatek.com> Subject: Re: [PATCH v2 7/7] meida: mtk-vcodec: remove unused func parameter On Wed, Nov 17, 2021 at 10:07 PM Dafna Hirschfeld <dafna.hirschfeld@...labora.com> wrote: > > The prarameter bs_size to function vpu_enc_encode > is not used. Remove it. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com> Indeed, it's an output parameter of the calling functions and has no business being passed to vpu_enc_encode. With the typo in the headline fixed, Reviewed-by: Alexandre Courbot <acourbot@...omium.org> > --- > drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c | 9 +++------ > drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c | 3 +-- > drivers/media/platform/mtk-vcodec/venc_vpu_if.c | 1 - > drivers/media/platform/mtk-vcodec/venc_vpu_if.h | 1 - > 4 files changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c > index b6a4f2074fa5..bf03888a824f 100644 > --- a/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c > +++ b/drivers/media/platform/mtk-vcodec/venc/venc_h264_if.c > @@ -367,8 +367,7 @@ static int h264_encode_sps(struct venc_h264_inst *inst, > > mtk_vcodec_debug_enter(inst); > > - ret = vpu_enc_encode(&inst->vpu_inst, H264_BS_MODE_SPS, NULL, > - bs_buf, bs_size, NULL); > + ret = vpu_enc_encode(&inst->vpu_inst, H264_BS_MODE_SPS, NULL, bs_buf, NULL); > if (ret) > return ret; > > @@ -394,8 +393,7 @@ static int h264_encode_pps(struct venc_h264_inst *inst, > > mtk_vcodec_debug_enter(inst); > > - ret = vpu_enc_encode(&inst->vpu_inst, H264_BS_MODE_PPS, NULL, > - bs_buf, bs_size, NULL); > + ret = vpu_enc_encode(&inst->vpu_inst, H264_BS_MODE_PPS, NULL, bs_buf, NULL); > if (ret) > return ret; > > @@ -451,8 +449,7 @@ static int h264_encode_frame(struct venc_h264_inst *inst, > mtk_vcodec_debug(inst, "frm_count = %d,skip_frm_count =%d,frm_type=%d.\n", > frame_info.frm_count, frame_info.skip_frm_count, > frame_info.frm_type); > - ret = vpu_enc_encode(&inst->vpu_inst, H264_BS_MODE_FRAME, frm_buf, > - bs_buf, bs_size, &frame_info); > + ret = vpu_enc_encode(&inst->vpu_inst, H264_BS_MODE_FRAME, frm_buf, bs_buf, &frame_info); > if (ret) > return ret; > > diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c > index 8267a9c4fd25..6b66957d5192 100644 > --- a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c > +++ b/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c > @@ -302,8 +302,7 @@ static int vp8_enc_encode_frame(struct venc_vp8_inst *inst, > > mtk_vcodec_debug(inst, "->frm_cnt=%d", inst->frm_cnt); > > - ret = vpu_enc_encode(&inst->vpu_inst, 0, frm_buf, bs_buf, bs_size, > - NULL); > + ret = vpu_enc_encode(&inst->vpu_inst, 0, frm_buf, bs_buf, NULL); > if (ret) > return ret; > > diff --git a/drivers/media/platform/mtk-vcodec/venc_vpu_if.c b/drivers/media/platform/mtk-vcodec/venc_vpu_if.c > index be6d8790a41e..e7899d8a3e4e 100644 > --- a/drivers/media/platform/mtk-vcodec/venc_vpu_if.c > +++ b/drivers/media/platform/mtk-vcodec/venc_vpu_if.c > @@ -225,7 +225,6 @@ int vpu_enc_set_param(struct venc_vpu_inst *vpu, > int vpu_enc_encode(struct venc_vpu_inst *vpu, unsigned int bs_mode, > struct venc_frm_buf *frm_buf, > struct mtk_vcodec_mem *bs_buf, > - unsigned int *bs_size, > struct venc_frame_info *frame_info) > { > const bool is_ext = MTK_ENC_CTX_IS_EXT(vpu->ctx); > diff --git a/drivers/media/platform/mtk-vcodec/venc_vpu_if.h b/drivers/media/platform/mtk-vcodec/venc_vpu_if.h > index f9be9cab7ff7..f83bc1b3f2bf 100644 > --- a/drivers/media/platform/mtk-vcodec/venc_vpu_if.h > +++ b/drivers/media/platform/mtk-vcodec/venc_vpu_if.h > @@ -45,7 +45,6 @@ int vpu_enc_set_param(struct venc_vpu_inst *vpu, > int vpu_enc_encode(struct venc_vpu_inst *vpu, unsigned int bs_mode, > struct venc_frm_buf *frm_buf, > struct mtk_vcodec_mem *bs_buf, > - unsigned int *bs_size, > struct venc_frame_info *frame_info); > int vpu_enc_deinit(struct venc_vpu_inst *vpu); > > -- > 2.17.1 >
Powered by blists - more mailing lists