linux-kernel - Re: [PATCH 04/13] media: s5p-mfc: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4197bba7-9827-7490-6ebd-f3c8da74b5ad@intel.com>
Date:   Tue, 28 Dec 2021 09:42:10 +0100
From:   Andrzej Hajda <andrzej.hajda@...el.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        <linux-media@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
CC:     Hans Verkuil <hverkuil-cisco@...all.nl>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>,
        Prabhakar <prabhakar.csengg@...il.com>,
        <linux-renesas-soc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 04/13] media: s5p-mfc: Use platform_get_irq() to get the
 interrupt


On 23.12.2021 18:30, Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Reviewed-by: Andrzej Hajda <andrzej.hajda@...el.com>

Regards

Andrzej

> ---
>   drivers/media/platform/s5p-mfc/s5p_mfc.c | 11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index f6732f031e96..761341934925 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -1268,7 +1268,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
>   {
>   	struct s5p_mfc_dev *dev;
>   	struct video_device *vfd;
> -	struct resource *res;
>   	int ret;
>   
>   	pr_debug("%s++\n", __func__);
> @@ -1294,12 +1293,10 @@ static int s5p_mfc_probe(struct platform_device *pdev)
>   	if (IS_ERR(dev->regs_base))
>   		return PTR_ERR(dev->regs_base);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	if (!res) {
> -		dev_err(&pdev->dev, "failed to get irq resource\n");
> -		return -ENOENT;
> -	}
> -	dev->irq = res->start;
> +	ret = platform_get_irq(pdev, 0);
> +	if (ret < 0)
> +		return ret;
> +	dev->irq = ret;
>   	ret = devm_request_irq(&pdev->dev, dev->irq, s5p_mfc_irq,
>   					0, pdev->name, dev);
>   	if (ret) {