linux-kernel - Re: [PATCH] staging: r8188eu: remove GET_CVID_ROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19a72e84-4962-8c10-0608-4081887312c2@gmail.com>
Date:   Tue, 28 Dec 2021 09:54:22 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove GET_CVID_ROM_VERSION

On 12/26/21 19:42, Michael Straube wrote:
> The macro GET_CVID_ROM_VERSION is not used. Remove it.
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>   drivers/staging/r8188eu/include/HalVerDef.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/include/HalVerDef.h b/drivers/staging/r8188eu/include/HalVerDef.h
> index 1d96657e6a98..62b94c993f0d 100644
> --- a/drivers/staging/r8188eu/include/HalVerDef.h
> +++ b/drivers/staging/r8188eu/include/HalVerDef.h
> @@ -35,7 +35,6 @@ struct HAL_VERSION {
>   #define GET_CVID_CHIP_TYPE(version)	(((version).ChipType))
>   #define GET_CVID_MANUFACTUER(version)	(((version).VendorType))
>   #define GET_CVID_CUT_VERSION(version)	(((version).CUTVersion))
> -#define GET_CVID_ROM_VERSION(version)	(((version).ROMVer) & ROM_VERSION_MASK)
>   
>   /* Common Macro. -- */
>   /* HAL_VERSION VersionID */

This patch is outdated, please drop it.
I'll resend it as part of a series.

Thanks,
Michael