linux-kernel - [PATCH] firmware: ti_sci: inproper error handling of ti_sci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_0D5124AF8235001703711A7A09703F918806@qq.com>
Date:   Tue, 28 Dec 2021 18:01:03 +0800
From:   Peiwei Hu <jlu.hpw@...mail.com>
To:     nm@...com, kristo@...nel.org, ssantosh@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Peiwei Hu <jlu.hpw@...mail.com>
Subject: [PATCH] firmware: ti_sci: inproper error handling of ti_sci_probe

goto out instead of returning directly in error exiting

Signed-off-by: Peiwei Hu <jlu.hpw@...mail.com>
---
 drivers/firmware/ti_sci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index 235c7e7869aa..4500456a9a27 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -3412,7 +3412,7 @@ static int ti_sci_probe(struct platform_device *pdev)
 		ret = register_restart_handler(&info->nb);
 		if (ret) {
 			dev_err(dev, "reboot registration fail(%d)\n", ret);
-			return ret;
+			goto out;
 		}
 	}
 
-- 
2.25.1