linux-kernel - Re: [PATCH] kobject: remove kset from struct kset_uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YcriB2fJM2O5NQIZ@kroah.com>
Date:   Tue, 28 Dec 2021 11:08:07 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wedson Almeida Filho <wedsonaf@...gle.com>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] kobject: remove kset from struct kset_uevent_ops
 callbacks

On Mon, Dec 27, 2021 at 08:41:36PM +0000, Wedson Almeida Filho wrote:
> On Mon, Dec 27, 2021 at 05:39:24PM +0100, Greg Kroah-Hartman wrote:
> > There is no need to pass the pointer to the kset in the struct
> > kset_uevent_ops callbacks as no one uses it, so just remove that pointer
> > entirely.
> 
> In the future, if someone needs the kset they can always find it by looking for
> the first non-null kset in the kobject or its parent chain, right? IOW, we're
> not losing any information by removing this.

Or even easier, we can add it back if needed :)

> > 
> > Cc: Rafael J. Wysocki <rafael@...nel.org>
> > Cc: Wedson Almeida Filho <wedsonaf@...gle.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Reviewed-by: Wedson Almeida Filho <wedsonaf@...gle.com>

Thanks for the review.

greg k-h