linux-kernel - Re: [PATCH 2/8] dt-bindings: rng: atmel,at91-trng: convert Atmel TRNG to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a3d7233-8ce0-dbb5-aac4-393caadf2a6a@canonical.com>
Date:   Tue, 28 Dec 2021 14:07:59 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
        Tomer Maimon <tmaimon77@...il.com>,
        Matt Mackall <mpm@...enic.com>,
        Avi Fishman <avifishman70@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Nishanth Menon <nm@...com>,
        Patrick Venture <venture@...gle.com>, openbmc@...ts.ozlabs.org,
        Pali Rohár <pali@...nel.org>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        linux-crypto@...r.kernel.org,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Tali Perry <tali.perry1@...il.com>, devicetree@...r.kernel.org,
        Benjamin Fair <benjaminfair@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Nancy Yuen <yuenn@...gle.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH 2/8] dt-bindings: rng: atmel,at91-trng: convert Atmel TRNG
 to dtschema

On 28/12/2021 13:54, Rob Herring wrote:
> On Mon, 27 Dec 2021 19:32:45 +0100, Krzysztof Kozlowski wrote:
>> Convert the Atmel TRNG bindings to DT schema.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>> ---
>>  .../bindings/rng/atmel,at91-trng.yaml         | 46 +++++++++++++++++++
>>  .../devicetree/bindings/rng/atmel-trng.txt    | 16 -------
>>  2 files changed, 46 insertions(+), 16 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml
>>  delete mode 100644 Documentation/devicetree/bindings/rng/atmel-trng.txt
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1573492
> 
> 
> rng@...10000: compatible:0: 'microchip,sama7g5-trng' is not one of ['atmel,at91sam9g45-trng', 'microchip,sam9x60-trng']
> 	arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
> 
> rng@...10000: compatible: Additional items are not allowed ('atmel,at91sam9g45-trng' was unexpected)
> 	arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
> 
> rng@...10000: compatible: ['microchip,sama7g5-trng', 'atmel,at91sam9g45-trng'] is too long
> 	arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
> 

This patch is only converting the existing bindings, so new compatible
is not added. The issue reported here is being fixed in the next patch
(3/8).

Best regards,
Krzysztof