linux-kernel - Re: [greybus-dev] [PATCH] staging: greybus: auto_manager: use default_groups in kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d25feae-aa07-f8f1-88b9-1209e57b9c2a@linaro.org>
Date:   Tue, 28 Dec 2021 08:25:15 -0600
From:   Alex Elder <elder@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Alex Elder <elder@...nel.org>, linux-staging@...ts.linux.dev,
        Johan Hovold <johan@...nel.org>, greybus-dev@...ts.linaro.org
Subject: Re: [greybus-dev] [PATCH] staging: greybus: auto_manager: use
 default_groups in kobj_type

On 12/28/21 7:55 AM, Greg Kroah-Hartman wrote:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field.  Move the greybus audio code to use default_groups field which
> has been the preferred way since aa30f47cf666 ("kobject: Add support for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
> 
> Cc: Vaibhav Agarwal <vaibhav.sr@...il.com>
> Cc: Mark Greer <mgreer@...malcreek.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alex Elder <elder@...nel.org>
> Cc: greybus-dev@...ts.linaro.org
> Cc: linux-staging@...ts.linux.dev
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Nice and simple to convert this (as it should be).
Looks good to me.

Reviewed-by: Alex Elder <elder@...aro.org>

> ---
>   drivers/staging/greybus/audio_manager_module.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index 525cf8f8394f..0a0f0a394c84 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -142,11 +142,12 @@ static struct attribute *gb_audio_module_default_attrs[] = {
>   	&gb_audio_module_op_devices_attribute.attr,
>   	NULL,   /* need to NULL terminate the list of attributes */
>   };
> +ATTRIBUTE_GROUPS(gb_audio_module_default);
>   
>   static struct kobj_type gb_audio_module_type = {
>   	.sysfs_ops = &gb_audio_module_sysfs_ops,
>   	.release = gb_audio_module_release,
> -	.default_attrs = gb_audio_module_default_attrs,
> +	.default_groups = gb_audio_module_default_groups,
>   };
>   
>   static void send_add_uevent(struct gb_audio_manager_module *module)
>