linux-kernel - Re: [PATCH] net: check passed optlen before reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211228155433.3b1c71e5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 28 Dec 2021 15:54:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tamir Duberstein <tamird@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: check passed optlen before reading

On Tue, 28 Dec 2021 16:02:29 -0500 Tamir Duberstein wrote:
> Errant brace in the earlier version.
> 
> From 8586be4d72c6c583b1085d2239076987e1b7c43a Mon Sep 17 00:00:00 2001
> From: Tamir Duberstein <tamird@...il.com>
> Date: Tue, 28 Dec 2021 15:09:11 -0500
> Subject: [PATCH v2] net: check passed optlen before reading
> 
> Add a check that the user-provided option is at least as long as the
> number of bytes we intend to read. Before this patch we would blindly
> read sizeof(int) bytes even in cases where the user passed
> optlen<sizeof(int), which would potentially read garbage or fault.
> 
> Discovered by new tests in https://github.com/google/gvisor/pull/6957 .
> 
> Signed-off-by: Tamir Duberstein <tamird@...il.com>

Your patches are corrupted by your email client.

Can you try sending the latest version with git send-email?