linux-kernel - Re: [syzbot] WARNING: ODEBUG bug in corrupted (2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE-0n52SNiv=GzDjM0nrvZzjLyttSjoNGAkz=Dvmt3R665mzug@mail.gmail.com>
Date:   Tue, 28 Dec 2021 21:41:17 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     hdanton@...a.com, keescook@...omium.org,
        linux-kernel@...r.kernel.org, miaoqinglang@...wei.com,
        qiang.zhang@...driver.com,
        syzbot <syzbot+a437546ec71b04dfb5ac@...kaller.appspotmail.com>,
        syzkaller-bugs@...glegroups.com, tglx@...utronix.de,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [syzbot] WARNING: ODEBUG bug in corrupted (2)

Quoting syzbot (2021-12-28 16:16:28)
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit:    ea586a076e8a Add linux-next specific files for 20211224
> git tree:       linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=12bb71a5b00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=a9c4e3dde2c568fb
> dashboard link: https://syzkaller.appspot.com/bug?extid=a437546ec71b04dfb5ac
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1246b50db00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=124c902db00000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+a437546ec71b04dfb5ac@...kaller.appspotmail.com

I see a fix has been sent[1] already. Here it is inline.

---8<---
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index eba1e8087bfd..b8b08f0a8c54 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -873,6 +873,7 @@ static int magicmouse_probe(struct hid_device *hdev,

 	return 0;
 err_stop_hw:
+	del_timer_sync(&msc->battery_timer);
 	hid_hw_stop(hdev);
 	return ret;
 }

>
> magicmouse 0003:05AC:0265.0001: hidraw0: USB HID v0.00 Device [HID 05ac:0265] on usb-dummy_hcd.0-1/input0
> magicmouse 0003:05AC:0265.0001: magicmouse input not registered
> magicmouse: probe of 0003:05AC:0265.0001 failed with error -12
> ------------[ cut here ]------------
> ODEBUG: free active (active state 0) object type: timer_list hint: magicmouse_battery_timer_tick+0x0/0x360 include/linux/device.h:693
> WARNING: CPU: 1 PID: 25 at lib/debugobjects.c:505 debug_print_object+0x16e/0x250 lib/debugobjects.c:505
> Modules linked in:
> CPU: 1 PID: 25 Comm: kworker/1:1 Not tainted 5.16.0-rc6-next-20211224-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Workqueue: usb_hub_wq hub_event
> RIP: 0010:debug_print_object+0x16e/0x250 lib/debugobjects.c:505
> Code: ff df 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 af 00 00 00 48 8b 14 dd 80 c1 05 8a 4c 89 ee 48 c7 c7 80 b5 05 8a e8 1e 28 25 05 <0f> 0b 83 05 35 9d a6 09 01 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e c3
> RSP: 0018:ffffc90000dfeb10 EFLAGS: 00010286
> RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
> RDX: ffff8880157d3a80 RSI: ffffffff815f4208 RDI: fffff520001bfd54
> RBP: 0000000000000001 R08: 0000000000000000 R09: 0000000000000001
> R10: ffffffff815edf6e R11: 0000000000000000 R12: ffffffff89adf420
> R13: ffffffff8a05bbc0 R14: ffffffff81666980 R15: dffffc0000000000
> FS:  0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007fff4e854bf0 CR3: 000000000b88e000 CR4: 00000000003506e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>

[1] https://lore.kernel.org/r/b0777c29fb4c59f27a726f62680b4c7f04c5c76e.1640725695.git.christophe.jaillet@wanadoo.fr