linux-kernel - [PATCH] ACPICA: DEBUGGER: Add return value check to acpi_db_walk_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211229174058.11350-1-shenzijun@kylinos.cn>
Date:   Thu, 30 Dec 2021 01:40:58 +0800
From:   shenzijun <shenzijun@...inos.cn>
To:     robert.moore@...el.com, rafael.j.wysocki@...el.com, lenb@...nel.org
Cc:     linux-acpi@...r.kernel.org, devel@...ica.org,
        linux-kernel@...r.kernel.org, jinzi120021@...a.com
Subject: [PATCH] ACPICA: DEBUGGER: Add return value check to acpi_db_walk_for_fields()

From: Zijun Shen <shenzijun@...inos.cn>

The function acpi_db_walk_for_fields frees buffer.pointer by the
first ACPI_FREE. And then uses the second ACPI_FREE to free
buffer.pointer which may assigns again in acpi_evaluate_object.
It's necessary to make sure that buffer.pointer get a block of
memory in acpi_evaluate_object and acpi_evaluate_object return 0.

Signed-off-by: Zijun Shen <shenzijun@...inos.cn>
---
 drivers/acpi/acpica/dbnames.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/dbnames.c b/drivers/acpi/acpica/dbnames.c
index 3615e1a6efd8..7a2d980cb2b8 100644
--- a/drivers/acpi/acpica/dbnames.c
+++ b/drivers/acpi/acpica/dbnames.c
@@ -550,7 +550,10 @@ acpi_db_walk_for_fields(acpi_handle obj_handle,
 	ACPI_FREE(buffer.pointer);
 
 	buffer.length = ACPI_ALLOCATE_LOCAL_BUFFER;
-	acpi_evaluate_object(obj_handle, NULL, NULL, &buffer);
+	status = acpi_evaluate_object(obj_handle, NULL, NULL, &buffer);
+	if (ACPI_FAILURE(status)) {
+		return (AE_OK);
+	}
 
 	/*
 	 * Since this is a field unit, surround the output in braces
-- 
2.31.1