linux-kernel - Re: [PATCH v6 1/3] certs: export load_certificate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Dec 2021 03:29:50 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Nayna Jain <nayna@...ux.ibm.com>
Cc:     linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
        dhowells@...hat.com, zohar@...ux.ibm.com,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, dimitri.ledkov@...onical.com,
        seth@...shee.me, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v6 1/3] certs: export load_certificate_list() to be used
 outside certs/

On Wed, Dec 22, 2021 at 08:39:17PM -0500, Nayna Jain wrote:
> load_certificate_list() parses certificates embedded in the kernel
> image to load them onto the keyring.
> 
> Commit "2565ca7f5ec1 (certs: Move load_system_certificate_list to a common
> function)" made load_certificate_list() a common function in the certs/
> directory. Now, export load_certificate_list() outside certs/ to be used
> by other functions.

It is exported to make callable by load_platform_certificate_list(). Making
anything callable by other functions by itself has no inherit value, and
does not serve as a stimulus to make such code change.

/Jarkko