linux-kernel - arch/x86/boot/compressed/../../../../lib/zstd/decompress/zstd_decompress_block.c:1390 ZSTD_decompressSequences() warn: inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 29 Dec 2021 12:24:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nick Terrell <terrelln@...com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: arch/x86/boot/compressed/../../../../lib/zstd/decompress/zstd_decompress_block.c:1390
 ZSTD_decompressSequences() warn: inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e7c124bd04631973a3cc0df19ab881b56d8a2d50
commit: e0c1b49f5b674cca7b10549c53b3791d0bbc90a8 lib: zstd: Upgrade to latest upstream zstd version 1.4.10
date:   7 weeks ago
config: x86_64-randconfig-m001-20211228 (https://download.01.org/0day-ci/archive/20211229/202112291237.Ilwkjozy-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
arch/x86/boot/compressed/../../../../lib/zstd/decompress/zstd_decompress_block.c:1390 ZSTD_decompressSequences() warn: inconsistent indenting
arch/x86/boot/compressed/../../../../lib/zstd/decompress/zstd_decompress_block.c:1414 ZSTD_decompressSequencesLong() warn: inconsistent indenting

Old smatch warnings:
arch/x86/boot/compressed/../../../../lib/zstd/decompress/huf_decompress.c:397 HUF_decompress4X1_usingDTable_internal_body() warn: maybe use && instead of &
arch/x86/boot/compressed/../../../../lib/zstd/decompress/huf_decompress.c:397 HUF_decompress4X1_usingDTable_internal_body() warn: maybe use && instead of &
arch/x86/boot/compressed/../../../../lib/zstd/decompress/huf_decompress.c:850 HUF_decompress4X2_usingDTable_internal_body() warn: maybe use && instead of &
arch/x86/boot/compressed/../../../../lib/zstd/decompress/huf_decompress.c:850 HUF_decompress4X2_usingDTable_internal_body() warn: maybe use && instead of &
arch/x86/boot/compressed/misc.c:292 parse_elf() warn: ignoring unreachable code.

vim +1390 arch/x86/boot/compressed/../../../../lib/zstd/decompress/zstd_decompress_block.c

  1369	
  1370	typedef size_t (*ZSTD_decompressSequences_t)(
  1371	                            ZSTD_DCtx* dctx,
  1372	                            void* dst, size_t maxDstSize,
  1373	                            const void* seqStart, size_t seqSize, int nbSeq,
  1374	                            const ZSTD_longOffset_e isLongOffset,
  1375	                            const int frame);
  1376	
  1377	#ifndef ZSTD_FORCE_DECOMPRESS_SEQUENCES_LONG
  1378	static size_t
  1379	ZSTD_decompressSequences(ZSTD_DCtx* dctx, void* dst, size_t maxDstSize,
  1380	                   const void* seqStart, size_t seqSize, int nbSeq,
  1381	                   const ZSTD_longOffset_e isLongOffset,
  1382	                   const int frame)
  1383	{
  1384	    DEBUGLOG(5, "ZSTD_decompressSequences");
  1385	#if DYNAMIC_BMI2
  1386	    if (dctx->bmi2) {
  1387	        return ZSTD_decompressSequences_bmi2(dctx, dst, maxDstSize, seqStart, seqSize, nbSeq, isLongOffset, frame);
  1388	    }
  1389	#endif
> 1390	  return ZSTD_decompressSequences_default(dctx, dst, maxDstSize, seqStart, seqSize, nbSeq, isLongOffset, frame);
  1391	}
  1392	#endif /* ZSTD_FORCE_DECOMPRESS_SEQUENCES_LONG */
  1393	
  1394	
  1395	#ifndef ZSTD_FORCE_DECOMPRESS_SEQUENCES_SHORT
  1396	/* ZSTD_decompressSequencesLong() :
  1397	 * decompression function triggered when a minimum share of offsets is considered "long",
  1398	 * aka out of cache.
  1399	 * note : "long" definition seems overloaded here, sometimes meaning "wider than bitstream register", and sometimes meaning "farther than memory cache distance".
  1400	 * This function will try to mitigate main memory latency through the use of prefetching */
  1401	static size_t
  1402	ZSTD_decompressSequencesLong(ZSTD_DCtx* dctx,
  1403	                             void* dst, size_t maxDstSize,
  1404	                             const void* seqStart, size_t seqSize, int nbSeq,
  1405	                             const ZSTD_longOffset_e isLongOffset,
  1406	                             const int frame)
  1407	{
  1408	    DEBUGLOG(5, "ZSTD_decompressSequencesLong");
  1409	#if DYNAMIC_BMI2
  1410	    if (dctx->bmi2) {
  1411	        return ZSTD_decompressSequencesLong_bmi2(dctx, dst, maxDstSize, seqStart, seqSize, nbSeq, isLongOffset, frame);
  1412	    }
  1413	#endif
> 1414	  return ZSTD_decompressSequencesLong_default(dctx, dst, maxDstSize, seqStart, seqSize, nbSeq, isLongOffset, frame);
  1415	}
  1416	#endif /* ZSTD_FORCE_DECOMPRESS_SEQUENCES_SHORT */
  1417	
  1418	
  1419	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org