linux-kernel - Re: mmotm 2021-12-29-20-07 uploaded (mm/damon)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1aaf9c11-0d8e-b92d-5c92-46e50a6e8d4e@linux.alibaba.com>
Date:   Thu, 30 Dec 2021 14:33:43 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Randy Dunlap <rdunlap@...radead.org>, akpm@...ux-foundation.org,
        broonie@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, sfr@...b.auug.org.au,
        SeongJae Park <sj@...nel.org>
Subject: Re: mmotm 2021-12-29-20-07 uploaded (mm/damon)

Hi,

On 12/30/2021 2:27 PM, Randy Dunlap wrote:
> Hi--
> 
> On 12/29/21 20:07, akpm@...ux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2021-12-29-20-07 has been uploaded to
>>
>>     https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
>>
>> The file broken-out.tar.gz contains two datestamp files: .DATE and
>> .DATE-yyyy-mm-dd-hh-mm-ss.  Both contain the string yyyy-mm-dd-hh-mm-ss,
>> followed by the base kernel version against which this patch series is to
>> be applied.
> 
> 
> On i386:
> 
> ../mm/damon/vaddr.c: In function ‘damon_hugetlb_mkold’:
> ../mm/damon/vaddr.c:402:17: warning: unused variable ‘h’ [-Wunused-variable]
>    struct hstate *h = hstate_vma(vma);

Ah, thanks for report, I think below changes can fix the warning. And 
I'll send a new version to address this warning.

diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index bcdc602..25bff8a 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -397,7 +397,6 @@ static void damon_hugetlb_mkold(pte_t *pte, struct 
mm_struct *mm,
                                 struct vm_area_struct *vma, unsigned 
long addr)
  {
         bool referenced = false;
-       struct hstate *h = hstate_vma(vma);
         pte_t entry = huge_ptep_get(pte);
         struct page *page = pte_page(entry);

@@ -414,7 +413,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct 
mm_struct *mm,
         }

  #ifdef CONFIG_MMU_NOTIFIER
-       if (mmu_notifier_clear_young(mm, addr, addr + huge_page_size(h)))
+       if (mmu_notifier_clear_young(mm, addr, addr + 
huge_page_size(hstate_vma(vma))))
                 referenced = true;
  #endif /* CONFIG_MMU_NOTIFIER */