linux-kernel - Re: [Resource Leak] Missing closing files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yc1YbthVqjBIAOyC@kroah.com>
Date:   Thu, 30 Dec 2021 07:57:50 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ryan Cai <ycaibb@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-m68k@...ts.linux-m68k.org
Subject: Re: [Resource Leak] Missing closing files

On Thu, Dec 30, 2021 at 11:04:58AM +0800, Ryan Cai wrote:
> Dear Kernel maintainers,
>  
>            In linux/drivers/zorro/gen-devlist.c, the file opened at Line 39 may not closed when going to Line 65. 
>  
>           I think, return 1 at Line 65 should be goto error. Should it be a bug? I can send a patch.
>  
> Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/drivers/zorro/gen-devlist.c#L39-L65

Do you use this program / file?

If so, and you can duplicate the problem, sure, send a patch after
testing it.

thanks,

greg k-h