linux-kernel - Re: [PATCH] lib/mpi: Add the return value check of kcalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca006060-10d8-bdd4-0824-943750542f61@linux.alibaba.com>
Date:   Thu, 30 Dec 2021 15:26:30 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     Zizhuang Deng <sunsetdzz@...il.com>, herbert@...dor.apana.org.au
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] lib/mpi: Add the return value check of kcalloc()



On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
> 
> Signed-off-by: Zizhuang Deng <sunsetdzz@...il.com>
> ---

Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>

Best regards,
Tianjia

>   lib/mpi/mpi-mod.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>   
>   	mpi_normalize(m);
>   	ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return NULL;
>   
>   	if (copy) {
>   		ctx->m = mpi_copy(m);