linux-kernel - [PATCH RESEND] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211230073225.30255-1-lukas.bulwahn@gmail.com>
Date:   Thu, 30 Dec 2021 08:32:25 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
        linux-block@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: [PATCH RESEND] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN

Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
config BLK_CGROUP_IOCOST.

Hence, ./scripts/checkkconfigsymbols.py warns:

  BLK_RQ_IO_DATA_LEN
  Referencing files: block/Kconfig

Probably, this select is just some unintended left-over from an earlier
draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
repository. So, drop this dead select to an undefined config.

Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
Acked-by: Tejun Heo <tj@...nel.org>
---
first submission:
https://lore.kernel.org/all/20211112093728.3237-1-lukas.bulwahn@gmail.com/

Patch is already acked by Tejun.
Jens, please pick this quick minor clean-up patch. 

 block/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/Kconfig b/block/Kconfig
index d5d4197b7ed2..80826e28d0d5 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -136,7 +136,6 @@ config BLK_CGROUP_FC_APPID
 config BLK_CGROUP_IOCOST
 	bool "Enable support for cost model based cgroup IO controller"
 	depends on BLK_CGROUP
-	select BLK_RQ_IO_DATA_LEN
 	select BLK_RQ_ALLOC_TIME
 	help
 	Enabling this option enables the .weight interface for cost
-- 
2.17.1