linux-kernel - Re: [PATCH] mmc: dw_mmc: Fix potential null pointer risk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <beeb83e9-415c-cf36-9cec-f9bc277442ed@samsung.com>
Date:   Thu, 30 Dec 2021 17:35:32 +0900
From:   Jaehoon Chung <jh80.chung@...sung.com>
To:     Wen Zhiwei <wenzhiwei@...inos.cn>, ulf.hansson@...aro.org,
        p.zabel@...gutronix.de
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Fix potential null pointer risk

On 12/29/21 11:38 AM, Wen Zhiwei wrote:
> we previously assumed 'host->slot' could be null,
> null pointer judgment should be added
> 
> Signed-off-by: Wen Zhiwei <wenzhiwei@...inos.cn>

Reviewed-by: Jaehoon Chung <jh80.chung@...sung.com>

Beset Regards,
Jaehoon Chung

> ---
>  drivers/mmc/host/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index d977f34f6b55..c9dc8c168efb 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3518,7 +3518,7 @@ int dw_mci_runtime_resume(struct device *dev)
>  	mci_writel(host, CTRL, SDMMC_CTRL_INT_ENABLE);
>  
>  
> -	if (host->slot->mmc->pm_flags & MMC_PM_KEEP_POWER)
> +	if (host->slot && host->slot->mmc->pm_flags & MMC_PM_KEEP_POWER)
>  		dw_mci_set_ios(host->slot->mmc, &host->slot->mmc->ios);
>  
>  	/* Force setup bus to guarantee available clock output */
>