linux-kernel - Re: [PATCH] connector: fix socket leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 09:47:06 +0100
From:   Greg KH <greg@...ah.com>
To:     ycaibb <ycaibb@...il.com>
Cc:     vapier@...il.com, zbr@...emap.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] connector: fix socket leak

On Thu, Dec 30, 2021 at 04:20:59PM +0800, ycaibb wrote:
> In main() of ucon.c, the socket may not be closed when send_msgs is true.
> 
> Signed-off-by: ycaibb <ycaibb@...il.com>

Please use your full name.

> ---
>  samples/connector/ucon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/samples/connector/ucon.c b/samples/connector/ucon.c
> index fa17f864200e..4f9d93a5c107 100644
> --- a/samples/connector/ucon.c
> +++ b/samples/connector/ucon.c
> @@ -180,7 +180,8 @@ int main(int argc, char *argv[])
>  
>  			ulog("%d messages have been sent to %08x.%08x.\n", i, data->id.idx, data->id.val);
>  		}
> -
> +		

Always run your patches through scripts/checkpatch.pl before sending
them out.

thanks,

greg k-h