linux-kernel - Re: [PATCH] x86/build: use the proper name CONFIG_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 10:29:34 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/build: use the proper name CONFIG_FW_LOADER

On Wed, Dec 29, 2021 at 08:36:11PM +0100, Borislav Petkov wrote:
> On Wed, Dec 29, 2021 at 12:15:53PM +0100, Lukas Bulwahn wrote:
> > Commit c8dcf655ec81 ("x86/build: Tuck away built-in firmware under
> > FW_LOADER") intends to add the expression regex only when FW_LOADER is
> > built-in, not a module or disabled.
> > 
> > The config is called CONFIG_FW_LOADER when it is built-in; and
> > CONFIG_FW_LOADER_MODULE when it is a module.
> 
> $ git grep FW_LOADER_MODULE
> include/linux/firmware.h:37:#if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE))
> 
> So either I'm not grepping right or that FW_LOADER_MODULE thing belongs
> to the past...
> 
> Greg, Luis, what's up?

Looks like a pre-git thing, it is obviously not a valid config option,
so it can be removed.  I'll go make a patch for it...

thanks,

greg k-h