linux-kernel - Missing closing files in linux/scripts/kconfig/confdata.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 11:11:33 +0800
From:   Ryan Cai <ycaibb@...il.com>
To:     <masahiroy@...nel.org>
CC:     <linux-kbuild@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Missing closing files in linux/scripts/kconfig/confdata.c

Dear Kernel maintainers,

          1. In linux/scripts/kconfig/confdata.c (conf_write_autoconf_cmd), the file opened at Line 946 may not closed when going to Line 981.
          Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L964-L981
         
         2. In linux/scripts/kconfig/confdata.c (__conf_write_autoconf), the file opened at Line1081 may not closed when going to Line 1095,
           Location: https://github.com/torvalds/linux/blob/e851dfae4371d3c751f1e18e8eb5eba993de1467/scripts/kconfig/confdata.c#L1081-L1095

           I think, the fix is inserting fclose before the returning. Should it be a bug? I can send a patch for these.


Best,
Ryan