linux-kernel - [goldwynr:iomap 4/33] fs/erofs/data.c:291:16: error: too few arguments to function 'iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 11:40:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Goldwyn Rodrigues <rgoldwyn@...e.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [goldwynr:iomap 4/33] fs/erofs/data.c:291:16: error: too few
 arguments to function 'iomap_readpage'

tree:   https://github.com/goldwynr/linux iomap
head:   30c74a8c201365178cae26d0d7aefa120c3245ab
commit: 0a74a7494220c731edd0f327149f56a4da3419c4 [4/33] iomap: Introduce iomap_readpage_ops
config: sparc64-buildonly-randconfig-r002-20211230 (https://download.01.org/0day-ci/archive/20211230/202112301130.El4IhQ3g-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/goldwynr/linux/commit/0a74a7494220c731edd0f327149f56a4da3419c4
        git remote add goldwynr https://github.com/goldwynr/linux
        git fetch --no-tags goldwynr iomap
        git checkout 0a74a7494220c731edd0f327149f56a4da3419c4
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc64 SHELL=/bin/bash fs/erofs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/erofs/data.c: In function 'erofs_readpage':
>> fs/erofs/data.c:291:16: error: too few arguments to function 'iomap_readpage'
     291 |         return iomap_readpage(page, &erofs_iomap_ops);
         |                ^~~~~~~~~~~~~~
   In file included from fs/erofs/internal.h:19,
                    from fs/erofs/data.c:7:
   include/linux/iomap.h:235:5: note: declared here
     235 | int iomap_readpage(struct page *page, const struct iomap_ops *ops,
         |     ^~~~~~~~~~~~~~
   fs/erofs/data.c: In function 'erofs_readahead':
>> fs/erofs/data.c:296:16: error: too few arguments to function 'iomap_readahead'
     296 |         return iomap_readahead(rac, &erofs_iomap_ops);
         |                ^~~~~~~~~~~~~~~
   In file included from fs/erofs/internal.h:19,
                    from fs/erofs/data.c:7:
   include/linux/iomap.h:237:6: note: declared here
     237 | void iomap_readahead(struct readahead_control *, const struct iomap_ops *ops,
         |      ^~~~~~~~~~~~~~~
   fs/erofs/data.c:296:16: error: 'return' with a value, in function returning void [-Werror=return-type]
     296 |         return iomap_readahead(rac, &erofs_iomap_ops);
         |                ^~~~~~~~~~~~~~~
   fs/erofs/data.c:294:13: note: declared here
     294 | static void erofs_readahead(struct readahead_control *rac)
         |             ^~~~~~~~~~~~~~~
   fs/erofs/data.c: In function 'erofs_readpage':
   fs/erofs/data.c:292:1: error: control reaches end of non-void function [-Werror=return-type]
     292 | }
         | ^
   cc1: some warnings being treated as errors


vim +/iomap_readpage +291 fs/erofs/data.c

eadcd6b5a1eb39 Gao Xiang 2021-08-13  284  
771c994ea51f57 Gao Xiang 2021-08-05  285  /*
771c994ea51f57 Gao Xiang 2021-08-05  286   * since we dont have write or truncate flows, so no inode
771c994ea51f57 Gao Xiang 2021-08-05  287   * locking needs to be held at the moment.
771c994ea51f57 Gao Xiang 2021-08-05  288   */
771c994ea51f57 Gao Xiang 2021-08-05  289  static int erofs_readpage(struct file *file, struct page *page)
771c994ea51f57 Gao Xiang 2021-08-05  290  {
771c994ea51f57 Gao Xiang 2021-08-05 @291  	return iomap_readpage(page, &erofs_iomap_ops);
771c994ea51f57 Gao Xiang 2021-08-05  292  }
771c994ea51f57 Gao Xiang 2021-08-05  293  
771c994ea51f57 Gao Xiang 2021-08-05  294  static void erofs_readahead(struct readahead_control *rac)
771c994ea51f57 Gao Xiang 2021-08-05  295  {
771c994ea51f57 Gao Xiang 2021-08-05 @296  	return iomap_readahead(rac, &erofs_iomap_ops);
771c994ea51f57 Gao Xiang 2021-08-05  297  }
771c994ea51f57 Gao Xiang 2021-08-05  298  

:::::: The code at line 291 was first introduced by commit
:::::: 771c994ea51f572539ca3961c6a7706862b147e2 erofs: convert all uncompressed cases to iomap

:::::: TO: Gao Xiang <hsiangkao@...ux.alibaba.com>
:::::: CC: Gao Xiang <hsiangkao@...ux.alibaba.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org