linux-kernel - Re: [Resource Leak] Missing closing files in testing/selftests/vm/mlock2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211229195135.959b3730c54652de497e932b@linux-foundation.org>
Date:   Wed, 29 Dec 2021 19:51:35 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Ryan Cai <ycaibb@...il.com>
Cc:     <shuah@...nel.org>, <linux-mm@...ck.org>,
        <linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Resource Leak] Missing closing files in
 testing/selftests/vm/mlock2

On Thu, 30 Dec 2021 11:17:37 +0800 Ryan Cai <ycaibb@...il.com> wrote:

> Dear Kernel maintainers,
>               1. In testing/selftests/vm/mlock2, the file opened at Line 39 may not closed when going to Line 65.
>               Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/tools/testing/selftests/vm/mlock2.h#L37-L49

That's what exit() does.  I don't think we really care unless the leak
is inside a loop.

That being said, it's untidy and is setting a poor example so I guess
we should fix it.

>               Can I send I a patch?

It would be better to just send the patch rather than preceding it
with "can I send a patch".  Everyone can send a patch and they are
encouraged to do so!