linux-kernel - Re: [PATCH] riscv: canaan: remove useless select of non-existing config SYSCON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Dec 2021 05:23:15 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: canaan: remove useless select of non-existing
 config SYSCON

On Wed, 2021-12-29 at 20:24 +0100, Lukas Bulwahn wrote:
> The config SYSCON never existed in the kernel repository; so, the select of
> that config in ./drivers/soc/canaan/Kconfig has no effect.
> 
> Presumably, this was just some mistake, assuming some symmetry in handling
> and naming of configs that simply does not exist.
> 
> Remove this useless select of a non-existing config.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  drivers/soc/canaan/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig
> index 853096b7e84c..2527cf5757ec 100644
> --- a/drivers/soc/canaan/Kconfig
> +++ b/drivers/soc/canaan/Kconfig
> @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
>  	depends on RISCV && SOC_CANAAN && OF
>  	default SOC_CANAAN
>          select PM
> -        select SYSCON
>          select MFD_SYSCON
>  	help
>  	  Canaan Kendryte K210 SoC system controller driver.

My bad :)

Reviewed-by: Damien Le Moal <damien.lemoal@....com>

-- 
Damien Le Moal
Western Digital Research