[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yc7e6V9/oioEpx8c@Red>
Date: Fri, 31 Dec 2021 11:43:53 +0100
From: Corentin Labbe <clabbe.montjoie@...il.com>
To: conleylee@...mail.com
Cc: davem@...emloft.net, kuba@...nel.org, mripard@...nel.org,
wens@...e.org, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] sun4i-emac.c: add dma support
Le Wed, Dec 29, 2021 at 09:43:51AM +0800, conleylee@...mail.com a écrit :
> From: Conley Lee <conleylee@...mail.com>
>
> Thanks for your review. Here is the new version for this patch.
>
> This patch adds support for the emac rx dma present on sun4i. The emac
> is able to move packets from rx fifo to RAM by using dma.
>
> Change since v4.
> - rename sbk field to skb
> - rename alloc_emac_dma_req to emac_alloc_dma_req
> - using kzalloc(..., GPF_ATOMIC) in interrupt context to avoid
> sleeping
> - retry by using emac_inblk_32bit when emac_dma_inblk_32bit fails
> - fix some code style issues
>
> Change since v5.
> - fix some code style issue
>
Hello
I just tested this on a sun4i-a10-olinuxino-lime
I got:
[ 2.922812] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitialized): get io resource from device: 0x1c0b000, size = 4096
[ 2.934512] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitialized): failed to request dma channel. dma is disabled
[ 2.945740] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitialized): configure dma failed. disable dma.
[ 2.957887] sun4i-emac 1c0b000.ethernet: eth0: at (ptrval), IRQ 19 MAC: 02:49:09:40:ab:3d
On which board did you test it and how ?
Regards
Powered by blists - more mailing lists